Repository navigation
Conversation
. new table format and preliminary migration tool . significant changes to manage event, delete event, and unit tests to accommodate new tables . jumps the calendar api version from 3.63.0 -> 3.64.0. the manage event response no longer returns the full event data. related: . extra command line control over app and unit test startup ( ex. to select mysql or sqlite for local testing ) . unit test files and test support code now live separately ( tests vs testing ) -- to make test file filtering easier . tests now uses a temp directory for images rather than the source control directory . better handling of thrown errors ( used by manage and delete ) to help with tests when they fail; . more throwable errors ( for manage and delete ) to simplify some code. . removes various unneeded functions . moves dev.env to root: this makes more sense to me . moves test images to their own directory ( separate from where images get uploaded )
includes the new tables, and support files; but doesn't change any of the existing code: purely additive
This reverts commit f5e4dce.
calConst replaced by newConst
move dev.env back into tools.
1. fix order of public schedule view -- sqlite was okay with it; mysql needed the order reversed 2. change view_combined_events to a regular join to avoid generating null pkids for events with no days
1. my development branch is using "shift root" but the migration tool and narrow db change needs to use "app root" ( based on the location of config.js ) to work like it used to 2. for easier testing with mysql in docker, add the ability to test against a fixed port
1. dont make all days today 2. clone days from the event data so munging a day doesn't affect all of the shared data 3. improve logged output for skipped days and invalid images
required giving the two methods both called getJSON separate names
- getStatusesByEventId was 'view_event_schedule' which only includes published days: it needed to use `view_all_days` to get at data for events which haven't yet been published. - updated those view names to be a little bit more self-documenting. - tweaked some of the tests to avoid creating data when the test didn't need to. - improved some comments
Contributor
Author
|
still remaining before changing the draft into a regular pr:
updates and fixes since the initial draft pr was created:
|
event creation was failing if no ridelength was selected. to match old code it needs to succeed.
ex. tests when running at the command line
reuse nullString in more places; and improve ridelength message
no longer needed with v2 tables
these are the same query now that there are no delisted days
note: console.assert logs, node assert rasises exceptions.
in events.js: - correctly handles if both id and range are specified - throws errors when possible because it simplifies the code.
was reporting iso date/time. regression introduced during the refactoring needed to support join'd views
app/eventimages was where php used to upload files, and it got reused image testing files. this... was confusing. and it meant new image files for testing couldn't be added without also updating gitignore. all the dev and test files live in /app/images now. and the gitignore can exclude the app/eventimages directory entirely
in v1 data, a missing tinytitle was autogenerated and stored into the db with v2 data, the tinytitle is null unless the organizer specifically provided one. the summary endpoint and the client code needs some adjustment to handle that.
- adds a 'revoked' column to cal_series to handle deleted rides - when deleting rides, set revoked info and delist all days - updates queries to handle delisted and deleted rides - restore 'all' query params to events and ics endpoints - updates migration to include deleted and delisted rides
sqlite is devonly, faker and proxy should be included by app root shouldn't have any direct dependencies i don't think anything was using "express-http-proxy
the hide/print flags were always false on the viewing endpoints ( non-editing ) because the view didn't include those columns. the actual data was always null because the code was asking for their v2 column names, not the legacy names ( ex. it was asking for ".private_email" which exists in the db, but the view renamed it to ".email", exactly so the code didn't have to change. )
to match legacy
1. the web info views weren't producing hideweb, printweb like they should have. 2. the field name changes for editing needed to be updated since the ones for viewing did ( ex. private_email is just email in the view )
Contributor
Author
|
doing manual comparisons of the events endpoint (ex. /api/events.php?startdate=2026-10-19&enddate=2026-10-21 ) i found and fixed some issues.
my migration script replaces windows style newlines ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
. new table format and preliminary migration tool
. significant changes to manage event, delete event, and unit tests to accommodate new tables
. jumps the calendar api version from 3.63.0 -> 3.64.0. the manage event response no longer returns the full event data.
https://github.com/ionous/shift-docs/blob/5106a1cf0eee1b9cde87f5dc8448a7a55df52d7b/docs/TABLES.md
related:
. extra command line control over app and unit test startup ( ex. to select mysql or sqlite for local testing )
. unit test files and test support code now live separately ( tests vs testing ) -- to make test file filtering easier
. tests now uses a temp directory for images rather than the source control directory
. better handling of thrown errors ( used by manage and delete ) to help with tests when they fail;
. more throwable errors ( for manage and delete ) to simplify some code.
. removes various unneeded functions
. moves dev.env to root: this makes more sense to me
. moves test images to their own directory ( separate from where images get uploaded )