Skip to content

Remove the pedalpalooza ical feed variant - #1111

Open
gangster wants to merge 2 commits into
shift-org:mainfrom
gangster:ical-pedalp-no-range
Open

gangster wants to merge 2 commits into
shift-org:mainfrom
gangster:ical-pedalp-no-range

Conversation

@gangster

@gangster gangster commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

The pedalpalooza feed URLs redirect to the shift calendar since d121187, so ?filename=pedalp... is no longer used. This removes the pedalpalooza calendar name, the closing event, and their tests.

Originally this fixed a 500 when filename=pedalp... was sent without an enddate; removing the code fixes that too.

A pedalp filename without an enddate tried to build the closing event
from an undefined date and returned 500.
@ionous

ionous commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

@gangster -- are you using that custom filename request in your app?

in d121187 we merged the pedalpalooza feed into the shift calendar feeds..... so, unless you need it for some reason, i think we should remove the backing code for it instead of fixing up the end date handling.

@ionous ionous left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( realized i should have marked this as "request changes" )

The pedalpalooza feed URLs now redirect to the shift calendar
(d121187), so nothing requests filename=pedalp anymore. Drop the
alternate calendar name, the closing event, and their tests.
@gangster gangster changed the title Skip the pedalpalooza closing event when there's no end date Remove the pedalpalooza ical feed variant Nov 12, 2026
@gangster

Copy link
Copy Markdown
Contributor Author

Not using it. My app only reads events.php. I switched this PR to remove the pedalpalooza special case: the calendar name and the "is over" event. The regular filename option still works. Happy to remove that too if you'd rather.

@ionous

ionous commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

nice! i think? we use the filename part from the front end... but i'll double check that.

@ionous ionous left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rocking. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants