Repository navigation
Conversation
A pedalp filename without an enddate tried to build the closing event from an undefined date and returned 500.
Contributor
ionous
requested changes
Nov 12, 2026
ionous
left a comment
Contributor
There was a problem hiding this comment.
( realized i should have marked this as "request changes" )
The pedalpalooza feed URLs now redirect to the shift calendar (d121187), so nothing requests filename=pedalp anymore. Drop the alternate calendar name, the closing event, and their tests.
Contributor
Author
|
Not using it. My app only reads |
Contributor
|
nice! i think? we use the filename part from the front end... but i'll double check that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pedalpalooza feed URLs redirect to the shift calendar since d121187, so
?filename=pedalp...is no longer used. This removes the pedalpalooza calendar name, the closing event, and their tests.Originally this fixed a 500 when
filename=pedalp...was sent without anenddate; removing the code fixes that too.