Repository navigation
fix: respect quotes/backslashes in prompt hooks - #449
Merged
ethanpailes merged 1 commit intoNov 5, 2026
Merged
Conversation
ethanpailes
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link
#437
AI Policy Ack
ack
Vibe-coded
This PR was:
Description
Fedora's default
PROMPT_COMMANDsets the terminal title withprintfand arguments with quotes/backslashes. In prompt.bash, shpool ends up parsing the hook text twice, leading to garbled and possibly harmful results when eval'd.Escaping the
$(\"${prompt_hook}\""->\"\${prompt_hook}\"") leaves expansion to the innereval.To pin the corrected handling, the test's
PROMPT_COMMANDis now aprintfwith quotes and\n.