Skip to content

Make tests pass on a 32-bit system. - #176

Merged
bors-servo merged 1 commit into
masterfrom
32
Oct 25, 2016
Merged

bors-servo merged 1 commit into
masterfrom
32

Conversation

@SimonSapin

@SimonSapin SimonSapin commented Oct 25, 2016 •

Copy link
Copy Markdown
Member

Testable on 64-bit Linux with:

rustup target add i686-unknown-linux-gnu
cargo test --target i686-unknown-linux-gnu

(or similarly on anther 64-bit platforms), assuming a linker and libc for this target are available on the system.

Leaving #162 open to add CI for this. (Unfortunately Travis doesn’t use rustup out of the box.)


This change is Reviewable

Testable on 64-bit Linux with:

```
rustup target add i686-unknown-linux-gnu
cargo test --target i686-unknown-linux-gnu
```

(or similarly on anther 64-bit platforms),
assuming a linker and libc for this target are available on the system.

Leaving #162 open to add CI for this.
(Unfortunately Travis doesn’t use rustup out of the box.)
@emilio

emilio commented Oct 25, 2016

Copy link
Copy Markdown
Member

@bors-servo r+

@bors-servo

Copy link
Copy Markdown
Contributor

📌 Commit 40d8629 has been approved by emilio

@bors-servo

Copy link
Copy Markdown
Contributor

⌛ Testing commit 40d8629 with merge 7379d87...

bors-servo pushed a commit that referenced this pull request Oct 25, 2016
Make tests pass on a 32-bit system.

Testable on 64-bit Linux with:

```
rustup target add i686-unknown-linux-gnu
cargo test --target i686-unknown-linux-gnu
```

(or similarly on anther 64-bit platforms), assuming a linker and libc for this target are available on the system.

Leaving #162 open to add CI for this. (Unfortunately Travis doesn’t use rustup out of the box.)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/string-cache/176)
<!-- Reviewable:end -->
@bors-servo

Copy link
Copy Markdown
Contributor

☀️ Test successful - status-travis

@bors-servo
bors-servo merged commit 40d8629 into master Oct 25, 2016
@SimonSapin
SimonSapin deleted the 32 branch October 25, 2016 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants