serverless v0.5 and optimizer #23

Activity

1. austencollins commented on Mar 19, 2016

   

   austencollins

   on Mar 19, 2016

   Member

   More actions

   Thanks, still fixing this. Almost done :)
2. ajagnanan commented on Mar 19, 2016

   

   ajagnanan

   on Mar 19, 2016

   Contributor

   More actions

   Should be good with #27 😄
3. purplecones commented on Mar 23, 2016

   

   purplecones

   on Mar 23, 2016

   More actions

   I get this error just by adding "serverless-optimizer-plugin" to the plugins array in s-project.json.

   /usr/local/lib/node_modules/serverless/node_modules/bluebird/js/release/async.js:49
           fn = function () { throw arg; };
                              ^
   
   TypeError: Class extends value #<Serverless> is not a function or null
       at module.exports.ServerlessPlugin.browserify._this.config.requires.map._this.config.plugins.map._this.config.transforms.map._this.config.exclude.forEach._this.config.ignore.forEach._generateIncludePaths (xxxxxx/node_modules/serverless-optimizer-plugin/index.js:21:37)
       at Serverless._loadPlugins (/usr/local/lib/node_modules/serverless/lib/Serverless.js:286:25)
       at Serverless.loadProjectPlugins (/usr/local/lib/node_modules/serverless/lib/Serverless.js:240:10)
       at /usr/local/lib/node_modules/serverless/lib/Serverless.js:77:41
   From previous event:
       at Serverless.init (/usr/local/lib/node_modules/serverless/lib/Serverless.js:73:25)
       at Object.<anonymous> (/usr/local/lib/node_modules/serverless/bin/serverless:17:12)
       at Module._compile (module.js:399:26)
       at Object.Module._extensions..js (module.js:406:10)
       at Module.load (module.js:345:32)
       at Function.Module._load (module.js:302:12)
       at Function.Module.runMain (module.js:431:10)
       at startup (node.js:141:18)
       at node.js:977:3
   

   and just running sls
4. martinmicunda commented on Mar 23, 2016

   

   martinmicunda

   on Mar 23, 2016

   Contributor

   More actions

   I am getting exactly same error like @purplecones (serverless v0.5.0)
5. ajagnanan commented on Mar 23, 2016

   

   ajagnanan

   on Mar 23, 2016

   Contributor

   More actions

   You should install latest master, install it by adding this to package.json

   "serverless-optimizer-plugin": "https://github.com/serverless/serverless-optimizer-plugin.git"
   

   ❤️React with ❤️1Reacted by Bradley Allen
6. martinmicunda commented on Mar 23, 2016

   

   martinmicunda

   on Mar 23, 2016

   Contributor

   More actions

   thanks @ajagnanan

   👍React with 👍3Reacted by Adrian Jagnanan, Bradley Allen and Thomas Kaul
7. patoncrispy commented on Apr 8, 2016

   

   patoncrispy

   on Apr 8, 2016

   More actions

   Using babelify and trying to run a function, I get the following error:

   class ServerlessOptimizer extends S.classes.Plugin {
                                               ^
   TypeError: Cannot read property 'Plugin' of undefined
    at module.exports.S.classes.Plugin.browserify._this.config.requires.map._this.config.plugins.map._this.config.transforms.map._this.config.exclude.forEach (/Users/CP/Development/project/node_modules/serverless-optimizer-plugin/index.js:20:46)
   

   My s-project.json has this defined:

   "custom": {
       "serverless-offline": {
         "babelOptions": {
           "presets": ["es2015"]
         }
       },
       "optimize": {
         "exclude": ["aws-sdk"],
         "transforms": [
           {
             "name": "babelify",
             "opts": {
               "presets": [
                 "es2015"
               ]
             }
           }
         ]
       }
     },
     "plugins": [
       "serverless-optimizer-plugin",
       "serverless-offline"
     ]
   

   My dependencies are:

   "dependencies": {
       "babel-preset-es2015": "^6.6.0",
       "babel-preset-stage-0": "^6.5.0",
       "babelify": "^7.2.0",
       "serverless-offline": "^2.2.9",
       "serverless-optimizer-plugin": "^2.4.0"
     }
   

   Any ideas why I would be getting this error?
8. martinmicunda commented on Apr 8, 2016

   

   martinmicunda

   on Apr 8, 2016

   Contributor

   More actions

   @patoncrispy you need to specify custom settings in s-function.json since serverless 0.5.0.. see issue #30
9. patoncrispy commented on Apr 8, 2016

   

   patoncrispy

   on Apr 8, 2016

   More actions

   So should I not have anything in my s-project.json, @martinmicunda? The docs suggest the following format:

   {
     "name": "projectName",
     "custom": {}, // For plugin authors to add any properties that they need
     "plugins": [] // List of plugins used by this project
   }
   
10. martinmicunda commented on Apr 8, 2016

    

    martinmicunda

    on Apr 8, 2016

    Contributor

    More actions

    you only move optimize config to s-function.json and everything else stay in s-project.json

    s-function.json

      "custom": {
        "excludePatterns": [
          "node_modules"
        ],
        "optimize": {
          "exclude": [
            "aws-sdk"
          ],
          "transforms": [
            {
              "name": "babelify"
            }
          ],
          "minify": true
        }
      },