Repository navigation
fix(reserved-instances-check): count reservations awaiting payment - #215
Merged
HarmonicTons merged 2 commits intoOct 23, 2026
Merged
Conversation
A reservation just bought, in particular on an account billed by invoice, stays in payment-pending for a while; it is committed capacity and must not be reported as uncovered. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
Update the success message and related descriptions so they accurately reflect payment-pending reservations.
1 open issue
What changed in this PR
Updates the reserved-instances check to count AWS reservations in payment-pending as committed capacity, preventing false uncovered-capacity alerts.
Changes:
- Includes
payment-pendingalongsideactivereservations for RDS and ElastiCache coverage. - Continues excluding
payment-failedandretiredreservations. - The success message and related descriptions still refer only to active reservations.
| File | Description |
|---|---|
actions/reserved-instances-check/check.py |
Counts active and payment-pending reservations when calculating covered capacity. |
Review effort: Lite
| RDS_NOT_BILLED_STATUSES = {"creating", "deleting", "deleted", "failed", "stopped", "stopping"} | ||
| ELASTICACHE_NOT_BILLED_STATUSES = {"creating", "deleting", "deleted", "create-failed", "incompatible-network"} | ||
| SKIPPED = [] | ||
| RESERVATION_STATES = {"active", "payment-pending"} |
Contributor
Author
There was a problem hiding this comment.
Fixed in 40b9cf8: the success line now reads “covered by reservations (active or awaiting payment)”, the docstring, action description and README say the same, and a pending reservation is labelled “(awaiting payment)” wherever it is listed, for instance in the expiring section.
…port Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reservations in state
payment-pendingnow count as reserved capacity, next toactive. A reservation just bought stays in that state until AWS registers the payment, which on an account billed by invoice can take a while; it is committed and irreversible, so reporting it as uncovered is a false alarm.payment-failedandretiredstay excluded.Seen today right after two purchases: the check still reported
mysql / db.m6gat 0 reserved andaurora-postgresql / db.r7gat 32. Checked with fixtures: the two pending reservations cover their pools, apayment-failedone is ignored.🤖 Generated with Claude Code