Repository navigation
chore: drop custom deployment Slack notifications in favor of the GitHub app - #211
Merged
cdelfabbro merged 2 commits intoOct 13, 2026
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments remain, and all reviewers assessed it as ready.
0 open findings
What changed in this PR
Replaces custom Slack deployment notifications with GitHub App notifications while preserving Datadog tracking and backward compatibility.
Changes:
- Removes custom Slack notifications from deployment workflows.
- Keeps deprecated Slack inputs for direct action callers.
- Corrects Datadog version fields.
- Updates documentation.
| File | Summary |
|---|---|
README.md |
Documents GitHub App notifications. |
actions/notify-deployment-in-progress-v2/action.yaml |
Removes Slack execution and fixes Datadog inputs. |
.github/workflows/terraform-deploy-v1.yml |
Removes Terraform Slack notifications. |
.github/workflows/netlify-deploy-v1.yml |
Removes the obsolete Slack token input. |
.github/workflows/ecs-deploy-v3.yml |
Removes ECS Slack notifications. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cdelfabbro
deleted the
chore/remove-custom-deployment-slack-notifications
branch
October 13, 2026 14:20
cdelfabbro
added a commit
that referenced
this pull request
Oct 13, 2026
…gress (#212) Follow-up of #211: `slack_bot_token`, `slack_channel` and `slack_notify` were kept as deprecated, ignored inputs while the repositories calling the action directly stopped passing them (hephaistos#1342, infrastructure-sencrop#2441, zephyr#230, dsp#1124, all merged). A code search of the org finds no caller passing them anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deployment notifications on Slack now come from the GitHub app, subscribed org-wide by workflow name in
#deployment-updates-prodand#deployment-updates-preprod. It covers every deployment workflow (migrations, smoke tests and all), including repositories created later, whereas our custom messages only covered the ECS/Terraform step.Changes
notify-deployment-in-progress-v2: the Slack step is removed, the Datadog event stays.slack_bot_token,slack_channelandslack_notifyare kept as deprecated, ignored inputs so the repositories calling the action directly (hephaistos, infrastructure-sencrop, zephyr, dsp) keep working until they are cleaned up.current_version,deployed_version) and read "updated from version to"; it now usesformer_versionandnew_version.ecs-deploy-v3andterraform-deploy-v1: the#ops/#ops-preprodsuccess and failure messages are removed, with theirnotify_on_successandslack_channelinputs. No repository of the org passes these inputs (checked with a code search).Note
The removed "Find slack channel" step also failed the job on an unknown environment. Nothing replaces that check: an unknown environment still fails later, at the
<environment>.tfvarslookup.