Repository navigation
Conversation
~/report_fault used the default service QoS, so its request queue held 10 requests. When more reporters reported at once than the queue held, the middleware dropped requests without an answer. Under load the FaultReporter retries met a full queue too, and some reports used all their attempts before they reached the manager. The queue now holds 100 requests. With a deeper queue a late answer is more likely than a lost request, so the FaultReporter docs now say that a report answered too late is sent again and every copy is processed.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
~/report_faultused the default service QoS, so its request queue held 10 requests. When more reporters reported at once than that, the middleware dropped the extra requests without an answer, and under load some reports never reached the manager. The queue now holds 100 requests.KEEP_ALL is not used: the response writer shares this QoS, and a client that stops acknowledging would fill its history until sending a response fails.
The FaultReporter docs now also say that a report answered later than
ack_timeout_secis sent again and processed once per copy.Issue
Type
Testing
test_deliveryinros2_medkit_fault_reportercovers it (test_burst_of_fresh_reporters_loses_nothing,test_events_of_one_code_arrive_in_order). It fails on main on Humble with Fast DDS on a 4-core machine and passes with this change.The Pixi (humble) workflow is the CI job that runs this combination. It runs on push to main and on schedule, so it was started by hand on this branch.
Checklist