Repository navigation
chore(build): source builds require Rust 1.99.1 - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raise the declared toolchain from Rust 1.99.0 to stable 1.99.1 in every place that states it:
The Rust CI job used the runner image's preinstalled stable (1.99.0), which rejects a crate declaring 1.99.1. It now installs the version
Cargo.tomldeclares, so the job always proves the advertised floor compiles instead of drifting behind it.Evidence
cargo buildon the runner —error: rustc 1.99.0 is not supported by the following package: selfhost-cli@0.3.2 requires rustc 1.99.1(run 39410711870).After: Rust job passes in 1m34s (run 39410845615).
cargo testlocally on 1.99.1 — 7 targets, 245 passed, 0 failed (174 unit, 18, 17, 15, 10, 6, 5).cargo clippy --all-targets— 0 warnings, 0 errors.cargo fmt --check— only the 7 pre-existing drift files named inAGENTS.md; none touched here.cargo metadatareports"rust_version":"1.99.1";rg "1\.99\.0"finds no stale references.target/debug/selfhost --versionprintsselfhost 0.3.2.Merge Danger
Door: two-way — revert restores the 1.99.0 floor.
Blast Radius: build-only.
Raising
rust-versiondrops 1.99.0 from the supported compilers for source builds. Anyone on 1.99.0 must update to build; published binaries are unaffected because they are built by the pinned release toolchain. CI now downloads the declared toolchain on every run instead of reusing the image's stable.