Repository navigation
Season 2a server operations (part A) - #13
Draft
pietechsolution wants to merge 15 commits into
Draft
pietechsolution wants to merge 15 commits into
pietechsolution wants to merge 15 commits into
Conversation
…s, event sales and event series
…wire tests, events seriesKey
…he p2a-api review
…tle (2.16c) createEventSeries takes fromEventKey: an event already set up becomes the first date under its own key and every other date is a copy of it; name and chartKey are then left out. Every date of a series carries the series' plain name. Matches seatmap slice 2.16c.
Adds releaseSeasonLapsedOffers (POST /v1/seasons/{key}/renewal-offers/release-lapsed, no body, header replay, 202 with the job). retrieveSeasonHostedRenewals pages with cursor and limit (1-500) and answers nextCursor, and listSeasonRenewalOffers pages the same way (1-100). createSeasonRenewalOffers answers 201 {offers} for 100 contracts or fewer and 202 {job, batchId} above that. The bring-across (createSeasonHolderImportFromSeason) answers 202 with a holder_import job above 100 holders. Renewal emails take up to 20,000 offer ids; above that, 422 too_many_offer_ids.
…e_abandoned (p2b) The public API changes in p2b (b88ed794e..ee7df2921): Seasons.dateCancelVoidJobId names the date_cancel_void job a date cancel starts (season.ticket.voided reason date_cancelled); Seasons.holderImportRowsPerCall sizes a createSeasonHolderImport call by its dates, 2 to 50 (a call over it answers 422 invalid_rows with maxRows); updateSeason's singleTicketDates can carry jobRefused, and an exact retry is not applied twice; createEventSeries documents 409 create_abandoned.
…b audit) updateEventSeries sends only the prices that change: each date keeps its own price for every category or tier left out. A season's null transfer or return cut-off means the club default from Settings > Ticket site, or until the date starts when the club has none. Holder transfers and returns through the secret key are not stopped by the club's customer switches; cut-offs still apply.
…part C) A date its season cancelled never opens again: moving its sales to testable or live, or reopening it, answers 409 season_date_cancelled, and an event series "sales on" leaves it closed as a failed item of the job (season_date_cancelled; not in failedDates). A cancelled date can't be moved, postponed, replaced or marked as taken place: 409 performance_cancelled.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for CI only. Do not merge: the season 2a SDK changes merge and release together at the end of 2a, on the owner's yes. No version bump, no tag.
What was added (71 operations, method names are the operationIds):
seasons(): 32 more Season methods (80 in all): performances, plan edits and deletion, publish, checkout tests, package prices, occurrence returns and reclaims, holders, Season order refunds and cancellations, hosted renewals, renewal links and notices, sales and seat reports, seat counts, holder and order CSV exports.holders()resource (11): customers, holder reads and updates, sign-out, seasons, tickets, ticket transfers.orders()resource (9): orders across events and seasons, one event's orders, CSV export, refunds, cancellations, ticket emails.events(): 14 event sales methods: buyer checkout, payment gateway, sales readiness, preflight, transition, booking fee, discount codes.eventSeries()resource (5): create, list, retrieve, add dates, update.getTextread, so the three CSV exports return the raw text. The two 204 deletes returnvoid.Idempotency-Key(caller's, or generated and reused on retry); the other 49 are single-attempt with no key.SeasonTestnow asserts all 80 season calls (verb, path with escaping, query, body, Idempotency-Key); newSeasonPlatformTestcovers holders, orders, event sales and event series the same way, plus raw CSV, 204s, header-replay retry and single-attempt behaviour.Local checks:
coverage.mjs --only java:java: 71/71 sent {"seasons":32,"holders":11,"orders":9,"eventSales":14,"eventSeries":5}.check-sdk-claims.mjs --routes javabefore and after: 138 to 209 routes, exactly the 71 new ones, none lost.@paramfor each parameter and@returnon non-void methods; no bare<,>or&in new javadoc; brackets balanced in every changed file.mvn -B verify(no JDK or Maven on this machine). CI is the compile, test and javadoc check.