Skip to content

Inconsistency in parameter filter_by_coordinate_system #433

Closed

Description

@melonora

When refactoring some code for #410 I noticed that there is an inconsistency in the parameters. In filter_by_coordinate_system we pass on element_paths_in_coordinate_system to _filter_table_by_coordinate_system. However, looking at this function the argument here refers to coordinate_system.

Activity

  1. LucaMarconato commented on Jan 17, 2024

    @LucaMarconato
    Member

    Well spotted, the argument of _filter_table_by_coordinate_system() (and the function name), should be renamed.

  2. linked a pull request that will close this issuemulti table support #455on Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    invalidThis doesn't seem right

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions