Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #252, #240
This PR includes fixes to two semi-related issues:
outline=True#252 is addressed in commit d73ccd3While digging around for a fix to #252, I also did some additional testing which led to:
NOTE: I'm not totally sure about the validity of the changes in 377e121, since I can't quite tell which case the
elsecode path is supposed to cover. From my experiments, it seemed like the code path of blendinglabels_infillandlabels_contourcould cover all combinations ofoutlineandalphaI tried, but it's absolutely possible I missed something here.As a comparison, I ran the following commands with and without these commits:
(the corresponding
outline=Falseplots look fine both with and without these changes)Without these commits, the outputs are:


(notice the artifact in the top-left, as reported in #252)
(notice the lack of fill even though
alpha=1.0, as reported in #240)With the fixes included here, the outputs are:

