Repository navigation
plan-feature: verify-citations fails closed on no input - #77
Merged
Merged
Conversation
Given an unreadable file argument or an empty list, the loop ran zero times and the script printed "All 0 citations resolve." with exit 0. Phase 1.4 treats exit 0 as "every citation is real", so a typo in the file name passed the gate having checked nothing. Both cases now exit 2 with a message on stderr. The suite gains three cases for them. Lifted from a consumer copy (Lokale Keuze, LK-1305). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Collaborator
|
SKILL.md should be updated alongside this fix. It still only explains MISSING and says "you may not proceed past Phase 1.4 with a non-zero exit". Exit 2 does block, correctly, but the agent isn't told what it means or what to do next. E.g. on skills/plan-feature/SKILL.md:198 and plugins/core-skills/skills/plan-feature/SKILL.md:200 the bold sentence becomes: A |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
verify-citations.shprintedAll 0 citations resolve.and exited 0 on two inputs that verified nothing:Phase 1.4 reads exit 0 as "every citation is real", so the gate passed having checked nothing. A consumer's reviewer caught it.
What
verify-citations.test.shgains three cases for them (35 assertions).skills/plan-feature/scripts/andplugins/core-skills/skills/plan-feature/scripts/.Not in this PR:
plugins/context-economy/lib/verify-citations.shhas the same fail-open behaviour (checked: empty stdin and a missing file both exit 0 with "All 0 citations resolve."). It is a separate plugin with its own release, so it is left for you to decide.From Lokale Keuze's copy of this skill (LK-1305).
No
plugin.jsonversion bump. This is one of eight parallel PRs from the same consumer, and each bump would collide on the same line. Bump on merge as you prefer.Test plan
/bin/bash3.2; shellcheck--severity=warningclean.🤖 Generated with Claude Code