Skip to content

Implement ScriptIOPlugin #94

Description

@hinerm

The ScriptIOPlugin exists as a shell right now. Its open method needs to be implemented:
https://github.com/scijava/scijava-common/blob/master/src/main/java/org/scijava/script/io/ScriptIOPlugin.java#L70

Currently this causes problems because the supportsOpen method is implemented, and is thus misleading.

Activity

  1. hinerm commented on Jul 14, 2014

    @hinerm
    MemberAuthor

    comments from ctrueden:
    (11:17:36 AM) ctrueden: My initial idea was that the Script Editor should probably be a DisplayViewer. Though every time we have to create new Displays it rubs the wrong way since it is too complex right now.
    (11:17:54 AM) ctrueden: The thing is, we need something like ScriptService#show(String script)
    (11:17:59 AM) ctrueden: But... what would it do? Publish an event, I think.
    (11:18:09 AM) ctrueden: And then something in imagej-ui-swing needs to pick up that event.
    (11:18:30 AM) ctrueden: Requires a little careful thought. Probably should file a GitHub issue for it.
    (11:19:01 AM) ctrueden: I think we should file that issue and then link it from the bugzilla and then not worry about it anymore today.

  2. hinerm commented on Jul 14, 2014

    @hinerm
    MemberAuthor

    As a quick fix we could make supportsOpen always return false.

  3. added this to the 3.0.0 milestone on Jul 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions