Repository navigation
Conversation
Keep handed lines when reported activity is only Unicode whitespace, preserve whole metric precision, and reserve the metric change at the trailing edge. Show measured progress independently of attention warmth, but never under human actions or reclaim offers. Exercise production project and overview paint with synthetic metric fixtures. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 61e79265-048f-4a4d-b414-c745b44ca098 Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Add entry ports and origins, quiet facing-edge routes, transparent folder bands, and overview connections without changing card or action geometry. Bind the direct export and hover consumers to their new exact production contracts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 66e55526-050a-4266-8650-99301ce14c3a Signed-off-by: Colin Neilens <coneilen@microsoft.com>
coneilen
added this pull request to stack #879
October 18, 2026 20:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore connected graph furniture on the Windows project and overview canvases without changing existing card placement, action bounds, or hit/UIA card geometry. This is a draft, Partial dependent layer above #872 (
coneilen-card-live-detail-parity, forke5564c024af4fce21f839a0a0d86aab76bafbb8f); it preserves that layer's card live-detail work.Changes
Source basis at macOS commit
2ccf303a04f995184aae1d4b738a9eca0f71b79e:graphcode\Sources\Features\Canvas\LoopCardView.swift:45-52,112-126;CanvasConnectorHandle.swift:11-20;CanvasEdgeGeometry.swift:63-101;CanvasBand.swift:22-38,167-240; andgraphcode\Sources\Features\Project\CanvasEdgeViews.swift:105-129. The relevant source files match this checkout. Ports/routing ownership is coordinated on #840; this work does not retroactively clear historical edge-oracle failures.Test plan
RED: & $env:GRAPHCODE_ZIG0152 test src\GraphCanvas.zig -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus "-I$env:GRAPHCODE_WINGHOSTTY_ROOT\include" --cache-dir D:\gc-lane7-tools\cache --global-cache-dir D:\gc-lane7-tools\global-cache --test-filter "connected canvas" -> inherited renderer: 0 passed; 0 skipped; 5 failed (TestUnexpectedResult: ports, reverse-curve hits, notebook visibility, overview edges, ENTRY origin).
GREEN: & $env:GRAPHCODE_ZIG0152 test src\GraphCanvas.zig -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus "-I$env:GRAPHCODE_WINGHOSTTY_ROOT\include" --cache-dir D:\gc-lane7-tools\cache --global-cache-dir D:\gc-lane7-tools\global-cache --test-filter "connected canvas" -> reviewed commit 52ffaa5: 8/8 passed, zero skips, native painting enabled.
REGRESSION: & $env:GRAPHCODE_ZIG0152 test src\GraphCanvas.zig -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus "-I$env:GRAPHCODE_WINGHOSTTY_ROOT\include" --cache-dir D:\gc-lane7-tools\cache --global-cache-dir D:\gc-lane7-tools\global-cache -> 330 named cases: 315 passed; 15 skipped; 0 failed on the default path.
Commands ran from
graphcode-windowswith the bootstrapped pinned Zig 0.15.2/provider and owned TEMP/cache roots. Focused native runs setGRAPHCODE_NATIVE_PAINT_TESTS=1; the complete default-path run did not. Its 15 skips are three opt-in exports plus twelve native-AA cases, not successful executions.Additional executed evidence:
--test-filter "loop card"and native painting enabled: 38/38 passed, zero skips, including the unchanged five edge-label tests. This is a separate native partition, not an unfiltered native-AA suite.pwsh -NoProfile -File Tools\windows\Tests\CanvasPaintArtifact.Tests.ps1 -ScratchRoot D:\gc-lane7-tools\contracts-for-pr: 11/11 native-log, 8/8 codec, 18/18 scene contracts passed. Before the converter change, its new four-edge overview round trip failed withPaintEvidenceInvalid, and the zero-edge negative incorrectly succeeded. The final exact profile accepts four and rejects zero/three/five while retaining all other negatives.& $env:GRAPHCODE_ZIG0152 build -Doptimize=ReleaseSafe "-Dwinghostty-dir=$env:GRAPHCODE_WINGHOSTTY_ROOT" -j1 --cache-dir D:\gc-lane7-tools\app-cache --global-cache-dir D:\gc-lane7-tools\global-cache --prefix D:\gc-lane7-tools\app-out: passed, with the pinned host built separately in its owned provider checkout.paint export: project-paint-v1andpaint export: overview-paint-764: 1/1 passed each, three identical RGB renders each, both accepted by the complete source/fixture/binary/log-bound converter at52ffaa5630fec24398468c8ab7edba9a84d1516f.Two existing native assertions initially failed because they assumed an opaque overview ground and sampled the stripe exactly where the new leading port belongs. The corrected tests retain every observation: halo contrast is measured against the actual grid/band background, and the stripe sample moves from y=48 to y=40, outside the source-derived 10-point port. No edge-pixel, ownership, or fixture-validation checks were relaxed. Initial test-syntax and compile failures were preserved separately and are not the behavioral RED evidence.
Limits: One private paired review against selected, correctly qualified 100% macOS references confirms visible component improvements, not equivalent topology or parity acceptance. Existing packed node placement and narrow gutters remain, rather than macOS graph-derived chains and its 62-point origin lane. Global START structure, origin-plus actions, richer aggregate/worktree captions, and inactive-project declared-entry propagation remain follow-ups; no unavailable data is invented. Bands are transparent outlines, not a claimed SwiftUI material/alpha-compositing match. No new desktop capture, physical input, native UIA/drag execution, daemon/backend/persistence, higher-DPI walkthrough, or macOS
make test/make checkwas run. Queued rail/grid/control/card-wrapper/reclaim work and the shared header are not part of this layer. The shared parity ledger is unchanged.Checklist
git commit -s) per the DCOmake test)make check)