Skip to content

check-ticket with no --sha off the ticket's branch judges the ticket's branch - #134

Merged
hhff merged 1 commit into
mainfrom
check-ticket-branch
Nov 7, 2026
Merged

hhff merged 1 commit into
mainfrom
check-ticket-branch

Conversation

@hhff

@hhff hhff commented Nov 7, 2026

Copy link
Copy Markdown
Member

What

  • devteam.mjs (check-ticket): with no --sha and --pr, when this checkout isn't on ticket/<id> (e.g. the supervisor's main checkout), it judges the head of ticket/<id> (local, else origin/) and prints which. On the ticket's own branch it still judges HEAD.
  • Test: check-ticket bill-01-card from the main checkout judges the ticket branch's head and passes.

Why

stacksbot: run from the supervisor's main checkout, check-ticket judged main's head, so every in-flight ticket read as missing its spec, plan and finals. That made the supervisor's check useless without --sha.

Migration

None. Passing --sha or --pr works as before.

🤖 Generated with Claude Code

…s branch

From the supervisor's main checkout, check-ticket <id> judged main's head (the
checkout's HEAD), so every in-flight ticket read as missing its spec, plan and
final reviews (stacksbot). With no --sha, and when this checkout isn't on
ticket/<id>, it now judges ticket/<id> (local, else origin's) and says so; on
the ticket's own branch it still judges HEAD, uncommitted work aside.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hhff

hhff commented Nov 7, 2026

Copy link
Copy Markdown
Member Author

Merging (upstream loop). Local Node 24.14.1, all files: 129/129. CI 18/20/22/24 is green.

@hhff
hhff merged commit 1eb8d1e into main Nov 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant