Repository navigation
Any capital-prefixed id is a review finding, not only F<n> - #133
Merged
Merged
Conversation
Review records were read for findings only on rows whose id was F<n>. Reviewers also prefix by kind (R1, S2, CR3, B4, ...): those rows were skipped, so check-ticket never required a disposition on a Critical or Important finding with such an id, and dispose refused to fill one (stacksbot: 120 records use them). A finding's id is now a short capital prefix and a number; check-ticket and dispose read them alike, and quality.md says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Merging (upstream loop). Local Node 24.14.1, all files: 129/129. CI 18/20/22/24 is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
devteam.mjs: a finding is a row under the Disposition-headed table whose id is a short capital prefix and a number (FINDING_ID:F1,R2,CR3,S1b).parseReview(and so check-ticket) anddisposeread them alike.quality.md§3: states the id form.R1with no disposition fails check-ticket, anddispose ... R1 fixedfills it.Why
Only
F<n>rows were findings. Reviewers also prefix by kind (stacksbot uses R, S, P, B, Q, T, C, D, G in 120 records), so check-ticket never required a disposition on a Critical or Important finding with such an id, anddisposerefused to fill one.Migration
check-ticket is stricter. A ticket whose review records have Critical or Important findings with non-F ids and no disposition now fails until they're disposed: run
devteam.mjs dispose <ticket> <record.md> <id> "fixed | wont-fix <reason> | wrong <reason>".🤖 Generated with Claude Code