Repository navigation
dispose fills a finding's Disposition cell in place; check-ticket warns on misshapen rows - #132
Merged
Merged
Conversation
…ns on misshapen rows
Authors filled an empty Disposition cell by hand and often appended a cell
instead ("… || fixed |"): check-ticket read the disposition past the extra
cell, but a fresh reviewer rejects the row, which cost stacksbot a full extra
review pass three times. `devteam.mjs dispose <ticket> <record.md> <F-id>
"<disposition>"` writes the cell, keeping the row the header's width; it takes
only a real disposition, and never changes one already given (as fill-in
allows). check-ticket warns on any finding row whose cell count differs from
its header, naming the command. quality.md §3 points authors at it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Merging (upstream loop). Local Node 24.14.1, all files: 129/129. CI 18/20/22/24 is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
devteam.mjs dispose <ticket> <record.md> <F-id> "<disposition>": fills that finding's Disposition cell in the ticket's review record, keeping the row the header's width.fixed,wont-fix <reason>,wrong <reason>).quality.md§3: authors fill dispositions withdispose.disposefills a cell and keeps 6 cells; it refuses a non-disposition, a second fill and a missing finding.Why
stacksbot (scripts-65, 184 and 185): authors filled an empty Disposition cell by hand by appending a cell (
… || fixed |). check-ticket read past it, but fresh reviewers rejected the row as malformed, which cost a full extra review pass each time.Migration
None. The warning is advisory.
🤖 Generated with Claude Code