Repository navigation
A flaky gate or test is a finding only while its last flip is recent - #131
Merged
Merged
Conversation
flaky-gate and flaky-test counted flips over all history, so one old flip, fixed or explained since, raised the same high finding every day for as long as the log lasts, and each ack hid it for a day (Stacks: four gates, all on flips from five days back). Each flaky gate and test now carries its last flip; the finding is raised only when that flip is within a week. The full history stays in metrics' gates.flaky_gates and flaky_tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Merging (upstream loop). Local Node 24.14.1, all files: 129/129. CI 18/20/22/24 is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
devteam.mjs(gateStats, findings): each flaky gate and flaky test now recordslast_flip. Theflaky-gateandflaky-testfindings are raised only when the last flip is within 7 days, and the detail names that date. The history stays inmetrics(gates.flaky_gates,gates.flaky_tests).flaky_gatesbut raises nothing;Why
Stacks re-acks four
flaky-gatefindings every 24 h (devteam, audit, coverage, test) for flips from 2026-11-01 to 05 that have since been explained. Counting over all history kept one old flip open forever.Not in this PR
Stacks also asked for an ack that lasts while an owner-accepted risk stands (e.g.
production-key-in-worktreesunder the owner's standing rule). That changes what a standing rule can do, so it goes to the owner first.Migration
None.
🤖 Generated with Claude Code