Repository navigation
A plan branch that came into main by a merge is not a planner in flight - #130
Merged
Merged
Conversation
planners() counted a plan branch as landed only when its own plan file was on
main. A design-change planner that wrote into another plan's file and merged
through that plan's PR left a branch fully in main, yet planner-gone flagged
it forever ("isn't on main", stacksbot plan/self-model-load-lanes), and ack
only hid it for 24 hours. A branch whose tip is in main but off main's
first-parent line came in by a merge, so it's done; a fresh planner's branch
sits on a first-parent commit and still shows.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Merging (upstream loop). Local Node 24.14.1, all files: 129/129. CI 18/20/22/24 is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
devteam.mjs(plannersNow): a plan branch whose tip is in main but off main's first-parent line came in by a merge, so it's done: it isn't listed as a planner, andplanner-gonedoesn't fire.--no-ffdisappears from the dashboard's planners and fromplanner-gone.Why
stacksbot's
plan-self-model-load-laneswas a design-change planner. It wrote intoplan-self-model's file and merged through #403, so its branch is fully in main (an ancestor with no commits outside main). Its own plan file was never on main, though, soplanner-gonesaid it "isn't on main" forever. Ack only hides a finding for 24 hours, and the org ruleset blocks deleting the branch.Migration
None.
🤖 Generated with Claude Code