Repository navigation
A task's later review pass, task-<n>-<pass>.md, is a review record - #126
Merged
Merged
Conversation
Task reviews are task-<n>.md, one per task, with no name for a second pass on the same task; workers write task-3-2.md. The verdict rule only recognised <stage>-<pass>[<track>].md as a record, so filling in that file's disposition counted as a change to the work and voided every final verdict after it (stacksbot scripts-28: its main merge looked like the cause; it wasn't). task-<n>-<pass>[<track>].md is now a record, and worker.md and quality.md name it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Merging (upstream loop). Local Node 24.14.1 main suite passed 49/49, including the task-1-2 fill-in. CI 18/20/22/24 is green at this head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
devteam.mjs(verdictHolds):task-<n>-<pass>[<track>].mdcounts as a review record, like<stage>-<pass>[<track>].md.worker.mdandquality.mdname the later-pass file.task-1-2.mddisposition after a final review keeps that review's verdict.Why
stacksbot's scripts-28 failed check-ticket after merging main, so the merge looked like the cause. It wasn't: the merge was clean, and the ticket's own diff was byte-identical. The real cause was a disposition fill-in on
task-3-2.md, a second-pass task review, which the verdict rule didn't recognise as a record. The docs gave no name for a task's later pass, so the worker's name was reasonable.Migration
None. Tickets voided this way pass check-ticket after the sync, with no new reviews.
🤖 Generated with Claude Code