Repository navigation
A standing rule for owner settings never approves kit files - #123
Merged
Merged
Conversation
merge's kit-file check (a chore touching files outside project/ needs the owner's answer) accepted any standing rule, including the one that settled the PR's owner settings. So with a class:gate-change rule (owner_rules, #115), a chore that added a gate could also edit the constitution, dropping governance-edit from owner_only, with no answer. Only the upstream-sync and CI-fix rules, which judge the kit files themselves, now satisfy the check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Merging (upstream loop). Local Node 24.14.1 main suite passed 49/49, including the new constitution-edit refusal. CI 18/20/22/24 is green at this head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
devteam.mjs(merge): only the upstream-sync and CI-fix standing rules, which judge the kit files themselves, satisfy the kit-file check (a chore touching files outsideproject/). The standing rule that settles a PR's owner settings no longer does.class:gate-changerule, a chore that adds a gate and editsconstitution.mdis refused with "touches files outside project/".Why
An independent review of #106 found this hole on main, introduced with #115 and shipped in v0.20.1. With the owner's
class:gate-changerule in place, the supervisor could merge a chore that added a gate and removedgovernance-editfromowner_onlyin the constitution, with no owner answer. The reviewer merged it for real in a fixture.Migration
None. A chore that changes kit files needs the owner's answer, as documented.
🤖 Generated with Claude Code