Repository navigation
Tests never reach the machine's default tmux server - #117
Merged
Merged
Conversation
tmux falls back to the default server when TMUX_TMPDIR names a directory that no longer exists. The "devteam kit" test's cleanup removed this run's private directory, so every later test's tmux call, kill-server included, went to the default server: running the suite on a machine with live devteam fleets killed them (stacksbot's, twice today). - A shim first on PATH runs tmux only while TMUX_TMPDIR is an existing private dt-tmux-* directory, and refuses otherwise. - The run's private directory is removed only at process exit, after its server; the fleet fixtures kill their own server before removing theirs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Merging (upstream loop): a test-only safety fix, and CI 18/20/22/24 is green. The shim was checked by hand (it passes with a live private dir, and refuses with a deleted one or none), and nothing calls tmux by an absolute path. The full local suite runs next as part of the v0.20.1 candidate, with this in it. |
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
test/kit.test.mjs:PATHruns the real tmux only whileTMUX_TMPDIRis an existing privatedt-tmux-*directory, and refuses (exit 1) otherwise.exithandler, after itskill-server, instead of in the "devteam kit" test'st.after.done()kills their own server before removing their directory.Why
tmux silently falls back to the default server when
TMUX_TMPDIRpoints at a deleted directory. I verified it:TMUX_TMPDIR=<deleted> tmux lslists the live fleet's session.The "devteam kit" test's cleanup deleted the private directory, and about 80 later top-level tests call tmux, including
kill-server. So running the full suite on a machine with live devteam fleets killed them: stacksbot's fleet was wiped twice today, at 20:40Z and 23:47Z. Thanks to the stacksbot supervisor for the report, and to the test-speed session for finding the mechanism. CI was never affected, since nothing else runs tmux there.Checked by hand:
TMUX_TMPDIRunset, it refuses;Migration
None. Tests only.
🤖 Generated with Claude Code