Skip to content

init fixes from stacksbot's adoption; the kit drops its forge workflow - #102

Merged
hhff merged 3 commits into
mainfrom
init-fixes
Nov 5, 2026
Merged

hhff merged 3 commits into
mainfrom
init-fixes

Conversation

@hhff

@hhff hhff commented Nov 5, 2026

Copy link
Copy Markdown
Member

What

  • scripts/devteam.mjs init:
    • refuses to run from a worktree;
    • sets main_branch from the remote's default branch (origin/HEAD, else git ls-remote --symref origin HEAD), never the current branch;
    • writes .gitkeep only in retros/ and reviews/;
    • drops --github and the WORKFLOW_YML template.
  • README step 3 and governance/quality.md: init runs from the main checkout and installs no forge workflow. The supervisor's merge is where devteam's checks run.
  • test/kit.test.mjs: a new init: test. The CI-fix test now models a project that kept the old workflow.

Why

  • stacksbot's supervisor hit three init defects when adopting v0.19.0; each is confirmed against the code.
  • The owner decided the kit drops devteam.yml. As a required check it failed every PR the fleet didn't make (feat/, fix/, humans, other sessions), and a project's normal CI is its own (the Baseline goal's gates).

Authority

Nothing new. Dropping the workflow removes only the forge's duplicate of checks that merge runs itself. The owner accepted that a merge through the forge's own button skips them.

Migration

None required. A project that has .github/workflows/devteam.yml from an earlier init --github may keep it, since check-pr still exists, or delete it (devteam-workflow / ci-fix chore rules still cover the edit). One that left it out, like stacksbot, is already in the new shape.

🤖 Generated with Claude Code

hhff and others added 2 commits November 4, 2026 22:58
…s merge refuses; the kit drops its forge workflow

From stacksbot's adoption (its supervisor's report, verified against the code):
- init run from a worktree put project/ in the worktree's kit folder and AGENTS.md, .gitignore
  and the workflow in the main checkout. It is refused there now.
- main_branch fell back to the branch the checkout was on when origin/HEAD is unset (a repo made
  with git init); it asks the remote now, and never takes the current branch.
- init made project/log/.gitkeep and project/tickets/.gitkeep, which merge refuses.
- The owner dropped devteam.yml (init --github): it failed every PR the fleet didn't make. The
  supervisor's merge is where devteam's checks run; the project's CI is its own. A project that
  kept the old workflow keeps working, and its CI-fix rule still can't drop or gut that check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…es no placeholder)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hhff

hhff commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

Review (upstream loop, author's own PR):

  • Verified: each of stacksbot's three init defects against the code, and the owner's decision to drop devteam.yml.
  • Authority: nothing widens. The forge's duplicate of merge's checks goes; the owner accepted that a click on the forge's own merge button skips them. The chore:devteam-workflow/ci-fix rule still covers projects that kept the old workflow, and its test now models one.
  • Fixed during review: the fleet test fixture assumed project/log/ existed. The kit's log-sync makes it, and every kit read checks existsSync.
  • Tests at 23d67b4: CI 18/20/22/24 green. Local Node 18.20.4, 24.14.1 and 20.19.6: 48/48 each.

@hhff
hhff merged commit d8dcc97 into main Nov 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant