Repository navigation
Conversation
… is never closed under it Node's 5s default keepAliveTimeout closed idle sockets that a client was about to reuse (Node 18's fetch keeps them about 4s), and that request failed with 'fetch failed'. That is the intermittent dashboard-test failure on macOS + Node 18, and browsers can hit the same race. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
keepAliveTimeoutto 65 s andheadersTimeoutto 66 s (keepAlive()).Keep-Alive: timeout=65.Why
The dashboard tests failed intermittently on macOS with Node 18, always as 'fetch failed' on the first request after a slow CLI step (secrets, review answers). Node's default 5 s
keepAliveTimeoutcloses an idle socket that Node 18's fetch (about 4 s idle reuse) can be just about to reuse, and that request fails. A server timeout longer than any client's means the client always closes first. Browsers hold idle sockets too, so an owner's click right after a pause could hit the same race.Migration
None. Restart the dashboard after the sync.
Tests
The hub test passes on Node 18. The full Node 18 suite on this branch, which is the real check that the two flaky tests stop failing, runs after the open PRs' local runs.
🤖 Generated with Claude Code