Skip to content

Replace tuples for arrays - #627

Draft
swfsql wants to merge 8 commits into
rust-ndarray:masterfrom
swfsql:replace-tuples-for-arrays
Draft

swfsql wants to merge 8 commits into
rust-ndarray:masterfrom
swfsql:replace-tuples-for-arrays

Conversation

@swfsql

@swfsql swfsql commented May 1, 2019

Copy link
Copy Markdown

Removes the features:

@bluss

bluss commented Aug 20, 2019 •

Copy link
Copy Markdown
Member

I'm skeptical of this change, but my vote doesn't necessarily matter.

Reasons:

  1. Less typing is better. Array::zeros(10) is good, no extra brackets needed. ((1, 2)) is less typing than ([1, 2]) because it is easy to repeat a keystroke
  2. It breaks about all code out there. As usual, try to deprecate a release before, if the change is to be done.

@bluss
bluss marked this pull request as draft April 17, 2020 11:05

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[de-feature request] tuples for const-defined dimensions

3 participants