You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I did this intentionally while implementing #717 because I didn't really want to expose the MultiSlice trait itself as part of the public API. Part of the reason I'm hesitant to expose it right now is that the trait should be improved once Rust has generic associated types. (The 'a and A should be moved to the Output associated type.)
Is there a particular reason to expose it other than for documentation purposes? If not, could we improve the documentation in other ways?
@jturner314 Thanks for the reply! Yes, I agree that we can expose this trait once we have the GAT.
Basically, I was trying to get a bunch of mutually disjointed mutable array views using multi_slice_mut. The problem I met was that what I got is a vector of ranges however the example in the documentation takes a tuple. I was trying to figure out what other types also implemented MultiSlice. However, the trait MultiSlice is unclickable due to being undocumented.
I'm totally fine with hiding MultiSlice until GAT landed since I can also read the source code.
Activity
jturner314 commentedon Jan 17, 2021
I did this intentionally while implementing #717 because I didn't really want to expose the
MultiSlicetrait itself as part of the public API. Part of the reason I'm hesitant to expose it right now is that the trait should be improved once Rust has generic associated types. (The'aandAshould be moved to theOutputassociated type.)Is there a particular reason to expose it other than for documentation purposes? If not, could we improve the documentation in other ways?
dovahcrow commentedon Jan 17, 2021
@jturner314 Thanks for the reply! Yes, I agree that we can expose this trait once we have the GAT.
Basically, I was trying to get a bunch of mutually disjointed mutable array views using
multi_slice_mut. The problem I met was that what I got is a vector of ranges however the example in the documentation takes a tuple. I was trying to figure out what other types also implemented MultiSlice. However, the trait MultiSlice is unclickable due to being undocumented.I'm totally fine with hiding MultiSlice until GAT landed since I can also read the source code.