Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is a bit special, because https://github.com/docker-library/official-images reads data from this repository from the
masterbranch by default (from this file).The second commit in this PR updates the config for that repo to read from the
mainbranch itself (modeled after e.g. dart), but that change won't be propagated immediately.So the rename on this repo should work as follows:
masterbranch on this repository tomain(as usually)mainbranch to amasterbranch on this repo (which will now be non-default), so thatofficial-imagesstill continue workingOnce
official-imagesis updated, we can remove themasterbranch. Note that it is important to actually rename themasterbranch tomain, rather than just create a newmainbranch, so redirects and the GitHub rename automation works as expected. Although I suspect that once we create a newmasterbranch, we will break the redirect links anyway.. But I'm not sure if that's super important. In theory we could also just not do the second step and just go updateofficial-images. I don't know if the update there is immediate, or if some old stuff might break.