This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Jul 31, 2023. It is now read-only.
RuboCop 0.72.0 removed -R option, causing Rails linting to fail #598
Description
Your environment
vscode-rubyversion:0.27.0- Ruby version:
any - Ruby version manager (if any):
asdf - VS Code version:
1.43.2 - Operating System:
macOS 10.14.6 - Using language server? (eg
useLanguageServeris true in your configuration?)Yes - RuboCop version:
>0.72.0
Expected behavior
"ruby.lint": {
"rubocop": {
"lint": true,
"rails": true
}
},
Adding this to my configuration should enable linting with rubocop, with rails cops enabled.
Actual behavior
Language Server Output:
Lint: executing rubocop -s <file> -f json -R -l...
invalid option: -R
The new way to use rails cops is to install the rubocop-rails gem and run RuboCop with rubocop --require rubocop-rails
I can make a PR for this to swap out the argument, but to maintain compatibility with older rubocops it may become more complicated.
Activity
jordanbrock commentedon May 11, 2020
Is there a config file based workaround for this in the meantime?
I've tried downgrading to 0.71 but it throws a few requirement errors for some other gems.
jordanbrock commentedon May 11, 2020
Actually, got it working with a mix of older gem versions:
But obviously, support for the latest versions would be preferred. I'm new to VSCode, so I'll have a poke around how extensions work and see if I can muddle a PR together at some point.
abraham-chan commentedon May 13, 2020
@jordanbrock Here's what I did to get linting working with rubocop >0.71
"rails": truefrom settings.jsonrequire: rubocop-railsto my.rubocop.ymlconfig file as per: https://github.com/rubocop-hq/rubocop-rails#rubocop-configuration-filegithub-actions commentedon Aug 8, 2020
This issue has not had activity for 30 days. It will be automatically closed in 7 days.
skipkayhil commentedon Aug 10, 2020
I can make a PR to update the docs later this week with the suggestion from @abraham-chan
github-actions commentedon Sep 10, 2020
This issue has not had activity for 30 days. It will be automatically closed in 7 days.
jhirn commentedon Oct 25, 2021
This still an actual problem. Experienced it today. Using
rails: truein the linter config add -R. I think this option should be removed entirely. The recommended way to include rails cops should come from rubocop.yml, not the linter configuration.estiens commentedon Feb 9, 2022
still a problem
lockieRichter commentedon Apr 18, 2023
Still seeing this issue more than a year later, currently using #598 (comment) as a workaround!