Skip to content

Add explicit GITHUB_TOKEN permissions to CI Test workflow - #74

Merged
dduugg merged 1 commit into
mainfrom
fix-code-scanning-alerts
Aug 17, 2026
Merged

dduugg merged 1 commit into
mainfrom
fix-code-scanning-alerts

Conversation

@dduugg

@dduugg dduugg commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

CodeQL actions/missing-workflow-permissions (alert #3) flagged the
build job in .github/workflows/build.yml, which had no effective
permissions block and so inherited the repository default.

The job only checks out the repo, installs Ruby and the bundle, and runs
rspec — it writes nothing back to GitHub — so a workflow-level
contents: read is the least privilege that keeps it working. Placed at
the workflow level (matching push_gem.yml in this repo) since build.yml
has a single job.

push_gem.yml and standardrb.yaml already declare permissions and are not
flagged; left untouched.

Alerts resolved

  • #3 actions/missing-workflow-permissions (medium) — .github/workflows/build.yml:5

Verification

  • Every job in every flagged workflow now has an effective permissions: block (cross-checked by parsing the YAML against the alert list).
  • actionlint output is byte-identical to main — no new findings introduced.
  • codeql.yml untouched.

CodeQL actions/missing-workflow-permissions (alert #3) flagged the
`build` job in .github/workflows/build.yml, which had no effective
permissions block and so inherited the repository default.

The job only checks out the repo, installs Ruby and the bundle, and runs
rspec — it writes nothing back to GitHub — so a workflow-level
`contents: read` is the least privilege that keeps it working. Placed at
the workflow level (matching push_gem.yml in this repo) since build.yml
has a single job.

push_gem.yml and standardrb.yaml already declare permissions and are not
flagged; left untouched.
@dduugg
dduugg requested a review from a team as a code owner August 17, 2026 19:34
@github-project-automation github-project-automation Bot moved this to Triage in Modularity Aug 17, 2026
@dduugg
dduugg merged commit 59b24ac into main Aug 17, 2026
10 checks passed
@dduugg
dduugg deleted the fix-code-scanning-alerts branch August 17, 2026 19:41
@github-project-automation github-project-automation Bot moved this from Triage to Done in Modularity Aug 17, 2026
@dduugg dduugg mentioned this pull request Sep 29, 2026
6 of 8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant