Repository navigation
Conversation
Ship the RBS type definitions with the gem, like base64 and bigdecimal, so that the signatures stay in sync with each released version. * sig/: copied as-is from ruby/rbs stdlib/pstore/0 * test_sig/: type tests restored from ruby/rbs test/stdlib/PStore_test.rb (removed in ruby/rbs@316e690b) * Add `rake rbs:test` and a sig workflow * Exclude test_sig/ from the gem package Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
They are implementation details and not part of the public API. Keep initialize since it defines the signature of new. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Add PStore::Error * Add thread_safe, ultra_safe and follow_symlink keyword arguments to PStore.new * Accept a default value of any type in PStore#fetch, as in `store.fetch(:nope, nil)` of the documentation Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test the types of each method signature rather than its behavior, using the examples from the documentation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Generate the RBS comments from the RDoc of lib. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ship the RBS type definitions with the gem, like base64 and bigdecimal, so that the signatures stay in sync with each released version. pstore is listed in
ALUMNI_STDLIBSof ruby/rbs, which expects the gem to ship its ownsig/directory.Changes
sig/pstore.rbs: based on ruby/rbsstdlib/pstore/0PStore::Errorthread_safe,ultra_safeandfollow_symlinkkeyword arguments toPStore.newPStore#fetchaccepts a default value of any type, as instore.fetch(:nope, nil)of the documentationrake rbs:annotatetest_sig/: type tests using the examples from the documentation, run byrake rbs:test.github/workflows/sig.yml: runsrbs validateandrake rbs:testGemfile: add an optionalsiggroup (rbs,rdoc)pstore.gemspec: excludetest_sig/from the packageHow to run
🤖 Generated with Claude Code