warning with ruby 2.7 #51

Activity

1. nobu commented on Oct 4, 2025

   

   nobu

   on Oct 4, 2025

   Last edited by nobu

   MemberAuthor

   More actions

   A plan I'm thinking is:

   1. revert Fixes for Data and add TruffleRuby in CI #20.
   2. release 0.6.3, the final version for ruby 2.
   3. bump up to 0.7.0.
   4. drop the support for ruby 2.
   5. re-apply Fixes for Data and add TruffleRuby in CI #20.

   @eregon How do you think?
2. eregon commented on Oct 4, 2025

   

   eregon

   on Oct 4, 2025

   Last edited by eregon

   Member

   More actions

   Sorry about the warning.

   Yes, that would work but seems higher effort than just checking while setting $VERBOSE to nil like:

   verbose, $VERBOSE = $VERBOSE, nil
   begin
     has_data_define = defined?(Data.define)
   ensure
     $VERBOSE = verbose
   end

   Also 2.7 is EOL for 2.5 years, I think such warnings or minor inconveniences are OK, and it would only affect 2.7 users keeping pp updated. So maybe it would be fine to do nothing?
   Not against fixing this though, especially with that has_data_define approach it's very simple.
3. eregon

   added a commit that references this issue on Oct 4, 2025

   Fix ::Data warning on Ruby 2.7

   ...

   4fd8f4e
4. eregon commented on Oct 4, 2025

   

   eregon

   on Oct 4, 2025

   Member

   More actions

   Proposed simple fix: #53
5. eregon commented on Oct 4, 2025

   

   eregon

   on Oct 4, 2025

   Member

   More actions

   BTW reverting the whole #20 seems bad, there are other commits which don't seem worth undoing & redoing, they are fine AFAIK. Could only revert & redo ed602b9 though.
6. nobu commented on Oct 4, 2025

   

   nobu

   on Oct 4, 2025

   MemberAuthor

   More actions

   Also 2.7 is EOL for 2.5 years, I think such warnings or minor inconveniences are OK, and it would only affect 2.7 users keeping pp updated. So maybe it would be fine to do nothing?

   I encountered test failures by this warning at bigdecimal with ruby 2.7.

   Well, I agree that 2.7 support will not matter nowadays, and propose the dropping it, like as 2-4 in #51 (comment).

   Proposed simple fix: #53

   It is almost same as my first fix, except for the variable name.

   BTW reverting the whole #20 seems bad, there are other commits which don't seem worth undoing & redoing, they are fine AFAIK. Could only revert & redo ed602b9 though.

   Ah, yes, my bad.
7. nobu

   closed this as completedin 4fd8f4eon Oct 4, 2025
8. nobu

   added a commit that references this issue on Oct 5, 2025

   [ruby/pp] Fix ::Data warning on Ruby 2.7

   ...

   3407770