Repository navigation
JITSupport use breaks tests under non-CRuby #2
Description
In 590e09b @k0kubun added logic to clear JIT logs during the popen2 test using JITSupport.
This breaks the test on implementations that do not have the same JIT flags and RubyVM support as CRuby.
If this logic is still necessary for the test to run on CRuby with JIT enabled, it should be masked to only run on CRuby. If it is no longer needed it should be reverted.
The rest of the jit_support.rb file does not seem to be used and was only ported over because it's used by the full test suite in CRuby (ac2e7bd by @hsbt).
I have some changes coming to let the open3 tests run on JRuby and include our Windows support files (JRuby only launches subprocesses through Java APIs on Windows, so different logic is required) and can also include this fix.
Activity
Only use JITSupport on CRuby
k0kubun commentedon Sep 29, 2021
Please feel free to branch based on
defined?(RubyVM::JIT)inremove_mjit_logsor its caller. Thank you.headius commentedon Sep 29, 2021
@k0kubun Will that get wiped out if someone updates
jit_support.rbfrom CRuby again? I do not know the CRuby stdlib maintenance workflow, but such things have happened in the past.k0kubun commentedon Sep 29, 2021
I have never sync-ed
test/libfrom ruby/ruby to other repositories. So it's up to hsbt. But I suppose you can also just update the same file in ruby/ruby if you have the concern.headius commentedon Sep 29, 2021
I will wait to hear from @hsbt before changing the logic in #3. Thanks!