You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixed Ctrl-C issue on Windows now, thank you for the pointing out. \r(= Ctrl-M) is the expected code for Enter.
It is translated to \n by console drivers when it is in "cooked" mode, and getch bypasses it.
Activity
nobu commentedon Nov 20, 2019
I cannot reproduce it.
What key do you press for
\n?orgads commentedon Dec 1, 2019
Here too, on Win10. See also JEG2/highline#244
I press Enter.
orgads commentedon Dec 1, 2019
orgads commentedon Dec 2, 2019
Same on Win7.
nobu commentedon Dec 2, 2019
The io-console bundled with 2.5 is quite old.
Could you try more recent versions?
orgads commentedon Dec 3, 2019
With the latest gem release it's the same, but with master here it kinda works. I get \r when pressing Enter (why not \n?)
Not sure if this is intended, but if I press Ctrl-C with the existing version I get char 3, but with master I get an Interrupt exception.
orgads commentedon Dec 3, 2019
I bisected the issue, and it was fixed in fae7933, which is included in 0.5.0.
Can you please push 0.5.0 to rubygems.org?
orgads commentedon Dec 3, 2019
On linux (debian) Enter produces \r as well, but Ctrl-C gives \u0003 and does not raise an exception.
nobu commentedon Dec 4, 2019
Fixed Ctrl-C issue on Windows now, thank you for the pointing out.
\r(= Ctrl-M) is the expected code for Enter.It is translated to
\nby console drivers when it is in "cooked" mode, andgetchbypasses it.orgads commentedon Dec 9, 2019
You may close this issue.
Can you please also publish binary packages for mingw to rubygems?
nobu commentedon Dec 10, 2019
We have dropped the binary gem support at 972ceb0.
c.f. ruby/bigdecimal#148