Skip to content

Specs fail on bundled gem on rubyci.org #29

Closed as not planned
Closed as not planned

Description

@mjago

I wrote some specs for DidYouMean module to satisfy ruby/spec issue #175.
These specs pass on ruby/spec CI (travis and appveyor).

However these specs fail all platforms on rubyci.org due to the specs being run before bundled gems (including did_you_mean) are downloaded - and were therefore reverted (PR #352).

Is this sequence by design on rubyci.org or should running specs be deferred until bundled gems are downloaded?

Activity

  1. eregon commented on Nov 11, 2016

    @eregon
    Member

    Ping @akr @hsbt.

    It also seems that did_you_mean is currently not tested at all?
    Maybe did_you_mean own tests should run on the built ruby?

  2. hsbt commented on Nov 11, 2016

    @hsbt
    Member

    In my personal opinion, We should not test bundled_gems such as did_you_mean, rake and etc.

    To maintain these gems leave from ruby core (and ruby/spec) responsibility.

  3. eregon commented on Nov 11, 2016

    @eregon
    Member

    My concern is some change in MRI could break the bundled version of did_you_mean.
    Without automatic testing, we will only know when a user reports it, which is fairly late (usually after release).

    For me, the only difference between bundled gems and stdlib is the packaging, both should be tested on MRI since they both come "with it". Otherwise there is a high risk to ship broken parts in a release.

  4. hsbt commented on Nov 11, 2016

    @hsbt
    Member

    My concern is some change in MRI could break the bundled version of did_you_mean.

    Agreed. I didn't provide this guard solution yet...

  5. hsbt commented on Jan 5, 2024

    @hsbt
    Member

    There is no plan to merge test-bundled-gems into chkbuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions