You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wrote some specs for DidYouMean module to satisfy ruby/spec issue #175.
These specs pass on ruby/spec CI (travis and appveyor).
However these specs fail all platforms on rubyci.org due to the specs being run before bundled gems (including did_you_mean) are downloaded - and were therefore reverted (PR #352).
Is this sequence by design on rubyci.org or should running specs be deferred until bundled gems are downloaded?
My concern is some change in MRI could break the bundled version of did_you_mean.
Without automatic testing, we will only know when a user reports it, which is fairly late (usually after release).
For me, the only difference between bundled gems and stdlib is the packaging, both should be tested on MRI since they both come "with it". Otherwise there is a high risk to ship broken parts in a release.
Activity
eregon commentedon Nov 11, 2016
Ping @akr @hsbt.
It also seems that
did_you_meanis currently not tested at all?Maybe
did_you_meanown tests should run on the built ruby?hsbt commentedon Nov 11, 2016
In my personal opinion, We should not test bundled_gems such as did_you_mean, rake and etc.
To maintain these gems leave from ruby core (and ruby/spec) responsibility.
eregon commentedon Nov 11, 2016
My concern is some change in MRI could break the bundled version of
did_you_mean.Without automatic testing, we will only know when a user reports it, which is fairly late (usually after release).
For me, the only difference between bundled gems and stdlib is the packaging, both should be tested on MRI since they both come "with it". Otherwise there is a high risk to ship broken parts in a release.
hsbt commentedon Nov 11, 2016
Agreed. I didn't provide this guard solution yet...
hsbt commentedon Jan 5, 2024
There is no plan to merge
test-bundled-gemsinto chkbuild.