Skip to content

Fix: Handle multi-line parameter definitions in GoogleParser - #98

Merged
mauvilsa merged 2 commits into
rr-:masterfrom
coolbeevip:issue-97
Jul 8, 2025
Merged

mauvilsa merged 2 commits into
rr-:masterfrom
coolbeevip:issue-97

Conversation

@coolbeevip

Copy link
Copy Markdown
Contributor

close #97

@coolbeevip

coolbeevip commented Jul 7, 2025 •

Copy link
Copy Markdown
Contributor Author

Hi @mauvilsa I just bump python to 3.9 to fix the issue of package docutils (0.21.post1) not found.

Additionally, during the repair stage, can we simplify the process by disabling workflow approval for public fork pull requests?

@mauvilsa

mauvilsa commented Jul 7, 2025

Copy link
Copy Markdown
Collaborator

Hi @mauvilsa I just bump python to 3.9 to fix the issue of package docutils (0.21.post1) not found.

I merged the hatchling pull request and it works even for python 3.8, see https://github.com/rr-/docstring_parser/actions/runs/16117095799/job/45473404596. Can you please rebase and not bump to 3.9.

Additionally, during the repair stage, can we simplify the process by disabling workflow approval for public fork pull requests?

I don't have permissions to change that. Also, requiring approval for first time contributors is basic to avoid random people using up compute credits.

@coolbeevip

coolbeevip commented Jul 7, 2025 •

Copy link
Copy Markdown
Contributor Author

Hi @mauvilsa

I've completed the rebase. By the way, regarding the removal of Poetry in #90, the contribution instructions in README.md might need to be updated.

@coolbeevip

Copy link
Copy Markdown
Contributor Author

Hi @mauvilsa Look at this CI failing. Pylint only supports Python 3.13 starting from version 3.3.0.

I just bumped Pylint to 3.37

@mauvilsa
mauvilsa merged commit fbe5336 into rr-:master Jul 8, 2025
@coolbeevip
coolbeevip deleted the issue-97 branch July 8, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GoogleParser fails to parse multi-line parameter definitions correctly

2 participants