Repository navigation
feat: support Example section for google docstring - #60
Closed
yewentao256 wants to merge 6 commits into
Closed
yewentao256 wants to merge 6 commits into
yewentao256 wants to merge 6 commits into
Conversation
rr-
requested changes
Nov 5, 2021
rr-
left a comment
rr-
left a comment
Owner
There was a problem hiding this comment.
Thank you for the pull request.
- Let's rename DocstringExamples to DocstringExample
- Let's add missing tests
- Please run black
- Please change
var # type hintto avar: TypeHint
Author
|
Thank you for the reply, I have submitted it again. |
rr-
requested changes
Nov 7, 2021
rr-
left a comment
rr-
left a comment
Owner
There was a problem hiding this comment.
Thanks for the changes. A couple of comments left:
Let's remove the assertions on docstring.meta.
Let's change the assertions on test_empty_example from docstring.meta to docstring.examples.
| return None | ||
|
|
||
| @property | ||
| def examples(self) -> T.Optional[DocstringDeprecated]: |
Author
|
Thanks for the reply, I've changed it. |
Owner
|
It's still |
Author
|
Oh I found it, thanks for figuring it out, it should be OK now. |
rr-
approved these changes
Nov 9, 2021
Owner
|
Merged manually. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.