Repository navigation
google: read named return heads - #191
Merged
Merged
Conversation
A Returns or Yields item written as "x (int): text" gave no type and no name, and kept the whole line as its description. Its head now gives the return's name and type, as BEHAVIOR.md describes, and composes back the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers item 9 from the BEHAVIOR.md review for #136: "
Returns/Yieldshold one item:type: text,name (type): textor just text."A Google return or yield written as
x (int): textused to give no type and no name, and the whole line became its description. Its head now setsreturn_nameandtype_name, and composing writes it back the same way. The head has to be one word followed by a type in parentheses, all on one line.Case diffs: one file,
rich.control.Control.move_to_column. ItsReturns:listsx (int)andy (int)as though they were args, so the single return now gets the namexand the typeint.Parity against origin/main: 55 of 29184 docstrings differ (case 1, stdlib 0, generated 54). The generated ones contain a named return head.