Repository navigation
Keep class attributes named like params - #162
Merged
Merged
Conversation
parse_from_object skipped a source attribute whose name the docstring used for anything, params included. A class documenting the __init__ param x lost its attribute x. Skip only names the docstring documents as attributes, which still win over the source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_from_object()dropped a class attribute when the class docstring documented a param of the same name. A common case is a class that documents its__init__params and stores them as attributes:Before,
parse_from_object(Point).attrswas empty. Now it holdsxwith "Where it is now.", andparamsstill holds the paramx. An attribute that the docstring itself documents still takes precedence over the one in the source.Parity: 0 of 29,123 docstrings differ. That's expected, since the parity tool doesn't run
parse_from_object.