Repository navigation
google+numpydoc: match section titles literally - #134
Merged
Merged
Conversation
Section titles went into the title regex as they were, while the parsers look sections up by their literal title. So a title such as "Notes?" was silently ignored, and one such as "C++ Notes" made building the parser raise re.error. Titles are now escaped.
rr-
force-pushed
the
escape-section-titles
branch
from
November 2, 2026 09:47
862ec12 to
efc46b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section titles went into the title regex unescaped, but the parsers look sections up by their literal title. So a custom title like
Notes?orArgs (old)was silently ignored, andC++ NotesmadeGoogleParser()raisere.error. Titles are now escaped in Google and Numpydoc.Since a title using regex syntax could never be looked up, nothing that worked before changes.