This repository was archived by the owner on Aug 11, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Aug 11, 2023. It is now read-only.
DefaultPublisher Leaks DefaultNode #237
Description
The DefaultPublisher class leaks the owning DefaultNode class. The corresponding TCP connection managers are also left open and are unable to be garbage collected. The fix is to shutdown the listeners in the DefaultPublisher and remove the publishers and subscribers from the DefaultNode's topicParticipantManager.
Reacted by Juan Ignacio Ubeira
Activity
adamantivm commentedon Mar 29, 2017
Thanks for this analysis @stratomda . Do you think you'll be submitting a fix for this as well?
stratomda commentedon Mar 29, 2017
@adamantivm I have fixed this and tested in indigo. I will update in the kinetic branch for ease of merging the pull request.
adamantivm commentedon Mar 29, 2017
sounds great. Thank you very much!
This fixes rosjava#237. Added fix to remove Publishers and Subscriber…
Enhancments to rosjava#237 fix. This moves shutdown responsibility to…
Merge pull request #238 from stratomda/fix/DefaultPublisherLeak
jubeira commentedon Mar 30, 2017
@adamantivm perhaps this could be cherrypicked to Indigo as well right?
adamantivm commentedon Mar 30, 2017
absolutely.