This repository was archived by the owner on Jan 14, 2023. It is now read-only.
Repository navigation
#37 is fixed - #38
Merged
Merged
#37 is fixed#38
Conversation
Contributor
|
How much testing did you do with messages? Just wondering if the switch from apache -> commons dependencies might cause unforeseen problems. |
Author
|
Hi Daniel, I don't have any special unit tests for this part of project. But there was some kind of integration testing: my project is working. It was tested at least on 3 robots. Each robot has two different Android devices (API Level 15+) with 12 ROS nodes communicating via ROS messages. I can't see any problems with them but the packages are in the Play Market and my friends can simply install them. |
Contributor
|
Ok, patching in. I'll migrate similar to indigo when I revisit the indigo build. |
stonier
added a commit
that referenced
this pull request
Nov 3, 2014
Contributor
|
Thanks! |
Author
|
Thanks for sharing your work, Daniel! From my friends, robots and me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made a fix for #37 bug: After publishing my Android app on Google Play I've got "Supported devices 0" warning. Please, update the dependencies in the message_generation module.