Repository navigation
restore . as parameter separator - #372
Merged
Merged
Conversation
Contributor
|
given this back and forth, I would suggest to put that prefix in a public header so that all other packages can depend on it (this holds for all tests as well as the yaml-parameter server for the ros2_control) |
dirk-thomas
approved these changes
Sep 12, 2017
Contributor
|
@Karsten1987 we'll need it in multi languages too. It's a little overkill but we could even put this sort of thing into message constants and leverage our generators to get it to any target language as a constant. |
tfoote
approved these changes
Sep 12, 2017
Member
Author
|
I'll merge this as is and ticket the fact that this separator should be exposed to downstream packages one way or another. I like the suggestion of putting it in a message constant in |
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
Signed-off-by: William Woodall <william@osrfoundation.org>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Deduplicate code in SequentialCompressionReader Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #367 (comment)