Skip to content

restore . as parameter separator - #372

Merged
mikaelarguedas merged 1 commit into
masterfrom
restore_dot_separator
Sep 12, 2017
Merged

mikaelarguedas merged 1 commit into
masterfrom
restore_dot_separator

Conversation

@mikaelarguedas

Copy link
Copy Markdown
Member

Follow up of #367 (comment)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Karsten1987

Copy link
Copy Markdown
Contributor

given this back and forth, I would suggest to put that prefix in a public header so that all other packages can depend on it (this holds for all tests as well as the yaml-parameter server for the ros2_control)

@tfoote

tfoote commented Sep 12, 2017

Copy link
Copy Markdown
Contributor

@Karsten1987 we'll need it in multi languages too. It's a little overkill but we could even put this sort of thing into message constants and leverage our generators to get it to any target language as a constant.

@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Sep 12, 2017
@mikaelarguedas

mikaelarguedas commented Sep 12, 2017 •

Copy link
Copy Markdown
Member Author

I'll merge this as is and ticket the fact that this separator should be exposed to downstream packages one way or another. I like the suggestion of putting it in a message constant in rcl_interfaces to store it in a single place and make it available to downstream code regardless of the language.
Ticketed in ros2/ros2#402

@mikaelarguedas
mikaelarguedas merged commit b68b761 into master Sep 12, 2017
@mikaelarguedas
mikaelarguedas deleted the restore_dot_separator branch September 12, 2017 15:43
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Sep 12, 2017
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
Signed-off-by: William Woodall <william@osrfoundation.org>
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
* Deduplicate code in SequentialCompressionReader

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants