Skip to content

Make sure the rclcpp tests depend on rosidl_runtime_cpp. - #363

Closed
clalancette wants to merge 1 commit into
masterfrom
rosidl_runtime_cpp-package
Closed

clalancette wants to merge 1 commit into
masterfrom
rosidl_runtime_cpp-package

Conversation

@clalancette

@clalancette clalancette commented Aug 25, 2017 •

Copy link
Copy Markdown
Contributor

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

relates to ros2/ros2#393

See CI in ros2/rosidl#231

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette added the in progress Actively being worked on (Kanban column) label Aug 25, 2017
@clalancette clalancette added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Aug 25, 2017
@clalancette

Copy link
Copy Markdown
Contributor Author

Since we decided to delay this until later, closing this PR; see ros2/ros2#393 for future work.

@clalancette clalancette closed this Sep 6, 2017
@clalancette clalancette removed the in review Waiting for review (Kanban column) label Sep 6, 2017
@clalancette
clalancette deleted the rosidl_runtime_cpp-package branch September 8, 2017 00:41
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
* add filter for selecting topics to read

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* add StorageFilter

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* add safety check for storage pointer; add reset_filter

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* add set_filter and reset_filter to Reader

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* fix mock sequential reader for rosbag2_transport test

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* add topic filter to transport play options

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* add selective topics to cmd line

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* fix cpplint

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* end to end read test

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* fix cmd line args

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* add play end to end test for filter topic

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* remove read test

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* remove read test in CMakeList

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* fix flake8

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* address PR comments

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* revert rosbag2_cpp Reader

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* unrevert rosbag2_cpp Reader

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* address PR comments

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* vector initialization

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* remove line break

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* fix merge errors

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* style

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* alpha order

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant