Skip to content

Remove unused test messages left over from topic statistics - #3346

Merged
ahcorde merged 1 commit into
rollingfrom
ahcorde/rolling/remove_unused_test_msgs
Oct 19, 2026
Merged

ahcorde merged 1 commit into
rollingfrom
ahcorde/rolling/remove_unused_test_msgs

Conversation

@ahcorde

@ahcorde ahcorde commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Description

'Header.msgandMessageWithHeader.msg` were added for the topic statistics tests (#1080). Those tests were removed along with the statistics feature, but the messages were still being generated and nothing used them.

This PR deletes both messages, their entries in the test rosidl_generate_interfaces call, and the builtin_interfaces dependency that only Header.msg needed.

No behavior change. The tests that use the remaining test messages build and pass.

Did you use Generative AI?

Claude Opus 5.5

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
ahcorde requested a review from jmachowinski October 15, 2026 13:34
@ahcorde ahcorde self-assigned this Oct 15, 2026
@github-actions

Copy link
Copy Markdown

ABI Compliance Check

✅ Verdict: compatible

Library Verdict Summary
libcomponent_manager.so ✅ compatible No ABI changes detected.
librclcpp.so ✅ compatible No ABI changes detected.
librclcpp_action.so ✅ compatible No ABI changes detected.
librclcpp_lifecycle.so ✅ compatible No ABI changes detected.
✅ libcomponent_manager.so — full abidiff report

Compared:

  • Base: lib-base/libcomponent_manager.so
  • Head: lib-pr/libcomponent_manager.so @ 4667d02
(empty report — no differences printed by abidiff)
✅ librclcpp.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp.so
  • Head: lib-pr/librclcpp.so @ 4667d02
(empty report — no differences printed by abidiff)
✅ librclcpp_action.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp_action.so
  • Head: lib-pr/librclcpp_action.so @ 4667d02
(empty report — no differences printed by abidiff)
✅ librclcpp_lifecycle.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp_lifecycle.so
  • Head: lib-pr/librclcpp_lifecycle.so @ 4667d02
(empty report — no differences printed by abidiff)

Updated for commit 4667d02 · check run · suppressions: /home/runner/work/_temp/ros2-abi-suppressions.txt

@ahcorde

ahcorde commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

Pulls: #3346
Gist: https://gist.githubusercontent.com/ahcorde/bc0d76461458d6324dfa3aada6eb5bbc/raw/90093527541319327bafcbdfc1ed5d78b7b90847/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/20788

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
ahcorde merged commit 7a29141 into rolling Oct 19, 2026
11 checks passed
@ahcorde
ahcorde deleted the ahcorde/rolling/remove_unused_test_msgs branch October 19, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants