Skip to content

[DO NOT MERGE][ABI test] 07: pimpl change in a private src/ header (expected compatible) - #3336

Closed
fujitatomoya wants to merge 1 commit into
rollingfrom
abi-test/07-pimpl-private-header
Closed

fujitatomoya wants to merge 1 commit into
rollingfrom
abi-test/07-pimpl-private-header

Conversation

@fujitatomoya

Copy link
Copy Markdown
Collaborator

Adds a data member and a method to Worker and to CBGScheduler in
rclcpp/src/rclcpp/executors/events_cbg_executor/scheduler.hpp. That header is not
installed; the public header only forward-declares CBGScheduler and holds it through a
std::unique_ptr. This replicates the false positive from #3277
(ros2-abi-action issue #15).

Expected: with the installed-headers rule (public-headers-regexp), every library
compatible, check passes, label ABI compatible. The diff job log should show the
generated public-headers.abignore covering the cbg_executor types.

This is a test pull request for the ABI checker (abi.yaml / abi-report.yaml, backed by
fujitatomoya/ros2-abi-action). It will be closed
without merging once the result has been checked. Do not review, do not merge.

🤖 Generated with Claude Code

…ler header

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Tomoya.Fujita <fujita.tomoya@triorb.co.jp>
@github-actions

Copy link
Copy Markdown

ABI Compliance Check

✅ Verdict: compatible

Library Verdict Summary
libcomponent_manager.so ✅ compatible No ABI changes detected.
librclcpp.so ✅ compatible No ABI changes detected.
librclcpp_action.so ✅ compatible No ABI changes detected.
librclcpp_lifecycle.so ✅ compatible No ABI changes detected.
✅ libcomponent_manager.so — full abidiff report

Compared:

  • Base: lib-base/libcomponent_manager.so
  • Head: lib-pr/libcomponent_manager.so @ a5b3466
(empty report — no differences printed by abidiff)
✅ librclcpp.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp.so
  • Head: lib-pr/librclcpp.so @ a5b3466
Functions changes summary: 0 Removed, 0 Changed (186 filtered out), 0 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable


✅ librclcpp_action.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp_action.so
  • Head: lib-pr/librclcpp_action.so @ a5b3466
(empty report — no differences printed by abidiff)
✅ librclcpp_lifecycle.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp_lifecycle.so
  • Head: lib-pr/librclcpp_lifecycle.so @ a5b3466
(empty report — no differences printed by abidiff)

Updated for commit a5b3466 · check run · suppressions: /home/runner/work/_temp/ros2-abi-suppressions.txt

@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

confirmed that result matches the expectation.

@ahcorde
ahcorde deleted the abi-test/07-pimpl-private-header branch October 19, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant