Skip to content

include rcutils/time - #333

Merged
mikaelarguedas merged 2 commits into
masterfrom
missing_time_include
Jun 5, 2017
Merged

mikaelarguedas merged 2 commits into
masterfrom
missing_time_include

Conversation

@mikaelarguedas

Copy link
Copy Markdown
Member

follow up of #332
Without this change rclcpp doesn't compile on my machine with a bunch of "not declared in this scope" errors

@mikaelarguedas mikaelarguedas added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jun 5, 2017
@dirk-thomas

Copy link
Copy Markdown
Member

Since the current state seems to build successfully on all platforms in the nightly jobs I am wondering what the difference is for you. Are you sure you have the latest version of all repos?

@mikaelarguedas

Copy link
Copy Markdown
Member Author

I am wondering what the difference is for you. Are you sure you have the latest version of all repos?

Me too, I'm looking into what can be different in my setup. I do think that we should include headers of functions that we use anyway so I opened the PR even if I'm not done tracking down where the discrepancy lies.

@mikaelarguedas

Copy link
Copy Markdown
Member Author

Looks like I was missing some changes in rcl. given that both rcl and rcutils export their include directories, this PR should not be necessary. Still feels weird to me to not explicitly include the headers for the functions / types we use directly in this file though.

@wjwwood wjwwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that if this file is using rcutils directly (not transitively), then it ought to include the header directly too. I'd 👍 this, but it's up to you @mikaelarguedas as to whether or not to run CI and all that to get it merged.

@dirk-thomas dirk-thomas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the reason of the change is clarified (include explicitly what is being used, rather then fix a problem) te change is absolutely fine with me. Maybe rcl/time.h should be included too?

@clalancette

Copy link
Copy Markdown
Contributor

@mikaelarguedas Good you figured out the difference, but ultimately I agree with you that we should include the headers that we need. So I'm +1 for this PR.

@mikaelarguedas

Copy link
Copy Markdown
Member Author

closing and reopening hoping that the second commit will show up

@mikaelarguedas mikaelarguedas reopened this Jun 5, 2017
@mikaelarguedas mikaelarguedas added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Jun 5, 2017
@mikaelarguedas

Copy link
Copy Markdown
Member Author
  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status (looks unrelated, @dirk-thomas are the logging tests known to be flaky ?)
  • Windows Build Status (unrelated flaky test)

@dirk-thomas

Copy link
Copy Markdown
Member

The tests of the throttle macros rely on waking up within (I think currently) 20ms. I have seen OS X being unreliable in that area before. So that is likely flaky. We could increase the time intervals which should make it less flaky for the the cost of taking longer.

@mikaelarguedas

Copy link
Copy Markdown
Member Author

So that is likely flaky. We could increase the time intervals which should make it less flaky for the the cost of taking longer.

I let you decide which solution you prefer. I just wanted to make sure you were aware of it.

Merging this then

@mikaelarguedas
mikaelarguedas merged commit a4f00dc into master Jun 5, 2017
@mikaelarguedas
mikaelarguedas deleted the missing_time_include branch June 5, 2017 21:42
@mikaelarguedas mikaelarguedas removed the in progress Actively being worked on (Kanban column) label Jun 5, 2017
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
This is an omnibus rollup of all of the previous commits
from ros2/rcl#333
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
* Query the QoS profiles for a topic to actually store them

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants