Repository navigation
include rcutils/time - #333
Conversation
|
Since the current state seems to build successfully on all platforms in the nightly jobs I am wondering what the difference is for you. Are you sure you have the latest version of all repos? |
Me too, I'm looking into what can be different in my setup. I do think that we should include headers of functions that we use anyway so I opened the PR even if I'm not done tracking down where the discrepancy lies. |
|
Looks like I was missing some changes in rcl. given that both rcl and rcutils export their include directories, this PR should not be necessary. Still feels weird to me to not explicitly include the headers for the functions / types we use directly in this file though. |
wjwwood
left a comment
There was a problem hiding this comment.
I agree that if this file is using rcutils directly (not transitively), then it ought to include the header directly too. I'd 👍 this, but it's up to you @mikaelarguedas as to whether or not to run CI and all that to get it merged.
dirk-thomas
left a comment
There was a problem hiding this comment.
Now that the reason of the change is clarified (include explicitly what is being used, rather then fix a problem) te change is absolutely fine with me. Maybe rcl/time.h should be included too?
|
@mikaelarguedas Good you figured out the difference, but ultimately I agree with you that we should include the headers that we need. So I'm +1 for this PR. |
|
closing and reopening hoping that the second commit will show up |
|
|
The tests of the throttle macros rely on waking up within (I think currently) 20ms. I have seen OS X being unreliable in that area before. So that is likely flaky. We could increase the time intervals which should make it less flaky for the the cost of taking longer. |
I let you decide which solution you prefer. I just wanted to make sure you were aware of it. Merging this then |
This is an omnibus rollup of all of the previous commits from ros2/rcl#333
* Query the QoS profiles for a topic to actually store them Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
follow up of #332
Without this change rclcpp doesn't compile on my machine with a bunch of "not declared in this scope" errors