Repository navigation
honor cancel() issued before spin_until_future_complete(). - #3174
Conversation
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
jmachowinski
left a comment
There was a problem hiding this comment.
We should also change the while loops in the spins, to only react to the cancel_request
|
Tick the box to add this pull request to the merge queue (same as
|
…e executor is still executing work. Signed-off-by: Tomoya Fujita <fujita.tomoya@triorb.co.jp>
|
Pulls: #3174 |
|
@jmachowinski thanks for your approval, i thought that you are on vacation 🍸 🏖️ |
|
I am, reading code reviews between swimming in the lake 😃 |
…before-spin jazzy: honor cancel() issued before spin() (backport ros2#3174) + sync with upstream jazzy 28.1.22
|
Great fix! Any chance this will be backported (lyrical)? |
|
I think this changed class layout and may not be ABI compatible. We could perhaps come up with a variant that does not modify class layout, but it might require a bit more effort |
Description
Fixes #3172
Is this user-facing behavior change?
Yes, but it only gets better.
Did you use Generative AI?
Yes, Claude Opus 4.7 partially, especially on test cases.
Additional Information