Skip to content

NEW PR: Add component_container for EventsExecutor - #2885

Merged
fujitatomoya merged 2 commits into
ros2:rollingfrom
mihirr-NV:rolling
Jun 28, 2025
Merged

fujitatomoya merged 2 commits into
ros2:rollingfrom
mihirr-NV:rolling

Conversation

@mihirr-NV

@mihirr-NV mihirr-NV commented Jun 26, 2025 •

Copy link
Copy Markdown
Contributor

Description

Add a component container for the events executor.

Is this user-facing behavior change?

No

Did you use Generative AI?

Yes

PR created by mihirr-NV
Code changes created with help from Cursor + gemini-2.5-pro.

Additional Information

N/A

Signed-off-by: Mihir Rao <mihirr@nvidia.com>
@mihirr-NV

Copy link
Copy Markdown
Contributor Author

@fujitatomoya Created a new and clean PR for this.

Comment thread rclcpp_components/CMakeLists.txt Resolved
Signed-off-by: Mihir Rao <mihirr@nvidia.com>

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i would like to have 2nd review for this.

CC: @alsora

Note

EventsExecutor is not explained in official documentation yet and still maintained under experimental namespace. We can follow up the component_container_event documentation once EventsExecutor is promoted to official Executor.

@alsora

alsora commented Jun 28, 2025

Copy link
Copy Markdown
Collaborator

CI

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya

Copy link
Copy Markdown
Collaborator

CI failures are unrelated to this PR. thanks for the contribution.

@fujitatomoya
fujitatomoya merged commit 5122c31 into ros2:rolling Jun 28, 2025
@ros-discourse

Copy link
Copy Markdown

This pull request has been mentioned on Open Robotics Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-performance-benchmarking/44382/5

@RBT22

RBT22 commented Aug 4, 2025

Copy link
Copy Markdown

Hi! Do you plan to backport this to jazzy?

bartalor pushed a commit to bartalor/rclcpp that referenced this pull request Jul 15, 2026
* Add component_container for EventsExecutor

Signed-off-by: Mihir Rao <mihirr@nvidia.com>

* Fix build error

Signed-off-by: Mihir Rao <mihirr@nvidia.com>

---------

Signed-off-by: Mihir Rao <mihirr@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants