Skip to content

use allocator via init_options argument. - #2129

Merged
fujitatomoya merged 1 commit into
rollingfrom
fujitatomoya/bugfix-rcl-issues-1036
Mar 17, 2023
Merged

fujitatomoya merged 1 commit into
rollingfrom
fujitatomoya/bugfix-rcl-issues-1036

Conversation

@fujitatomoya

Copy link
Copy Markdown
Collaborator

part of ros2/rcl#1036, but independent bug fix.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Comment thread rclcpp/src/rclcpp/context.cpp Resolved
@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

@ros-pull-request-builder retest this please

@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, the allocator is being used before we initialize init_options_. Switching to the passed-in init_options fixes it.

@clalancette

Copy link
Copy Markdown
Contributor

That said, I suggest we run CI with --packages-above rclcpp, because this touches the init code. Once that is green, I'm happy to merge this in.

@fujitatomoya
fujitatomoya merged commit 1a796b5 into rolling Mar 17, 2023
@delete-merged-branch
delete-merged-branch Bot deleted the fujitatomoya/bugfix-rcl-issues-1036 branch March 17, 2023 19:35
@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

@Mergifyio backport humble

@mergify

mergify Bot commented Mar 17, 2023 •

Copy link
Copy Markdown
Contributor

backport humble

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Mar 17, 2023
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 1a796b5)
@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

@clalancette sorry i missed your comment, browser cache or something did not show it. i will start the CI as you suggested.

@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

all test passed but it show failing signs, i am not sure what went wrong.

@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

I think build / test option was not correct.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

unstable failure is not related to this PR.

fujitatomoya pushed a commit that referenced this pull request Mar 20, 2023
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 1a796b5)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Barry-Xu-2018 pushed a commit to Barry-Xu-2018/rclcpp that referenced this pull request Jan 12, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
bartalor pushed a commit to bartalor/rclcpp that referenced this pull request Jul 15, 2026
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants